Open
Conversation
sttaran
approved these changes
Mar 19, 2024
cypress/e2e/auth/login.spec.js
Outdated
| @@ -0,0 +1,11 @@ | |||
| import AuthTab from "../../page-Objects/AuthTab.js"; | |||
|
|
|||
| const authTab = new AuthTab(); | |||
Owner
There was a problem hiding this comment.
authPage, why did you call it tab?
cypress/page-Objects/AuthTab.js
Outdated
| @@ -0,0 +1,12 @@ | |||
| import { faker } from '@faker-js/faker'; | |||
|
|
|||
| class AuthTab { | |||
cypress/page-Objects/AuthTab.js
Outdated
| import { faker } from '@faker-js/faker'; | ||
|
|
||
| class AuthTab { | ||
| login() { |
Owner
There was a problem hiding this comment.
pass values into a method, do not generate it here
| import { faker } from '@faker-js/faker'; | ||
|
|
||
| class SmartTablePage { | ||
| createUser() { |
sttaran
requested changes
Mar 19, 2024
| @@ -0,0 +1,11 @@ | |||
| import AuthPage from "../../page-Objects/AuthTab.js"; | |||
|
|
|||
| const authPage = new AuthPage(); | |||
Comment on lines
14
to
19
| cy.get("tbody") | ||
| .should("be.visible") | ||
| .within(() => { | ||
| cy.get(".ng2-smart-row").should("have.length", 1); | ||
| smartTablePage.verifyCreatedUserData(newUser); | ||
| }); |
cypress/page-Objects/AuthTab.js
Outdated
| import { faker } from '@faker-js/faker'; | ||
|
|
||
| class AuthTab { | ||
| login() { |
| import { faker } from '@faker-js/faker'; | ||
|
|
||
| class SmartTablePage { | ||
| createUser() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request (check one with "x"):
Short description of what this resolves: